[Jde-dev] warnings en jderobot 5.0

[David Lobato]

Hola,

Compilando hoy jderobot 5.0 he visto que hay un montón de warnings.
Tenemos que cuidar un poco esto, para que no crezca y luego haya que
dedicar un montón de tiempo a limpiarlos. Algunos no cuesta nada
eliminarlos, simplemente siendo estrictos y escribiéndolo bien desde
el principio.

Creo que es una política acertada tratar los warnings al mismo nivel
que errores, y tratar por todos lo medios de eliminarlos cuando
aparezcan.

Aquí pongo unos cuantos que he encontrado.

Un saludete,
David.

src/components/introrob/Makefile.am:10: LIBGNOMEUI-DEV_CPPFLAGS:
non-POSIX variable name
src/components/introrob/Makefile.am:14: LIBGNOMEUI-DEV_LDFLAGS:
non-POSIX variable name


cameraserver.cpp:270:1: warning: "YUV2RGB" redefined
In file included from /usr/include/dc1394/dc1394.h:49,
                 from /usr/include/dc1394/log.h:45,
                 from /usr/include/dc1394/control.h:23,
                 from cameraserver.cpp:41:
/usr/include/dc1394/conversions.h:72:1: warning: this is the location
of the previous definition

cameraserver.cpp: In member function ‘virtual void
cameraserver::CameraI::stopCameraStreaming(const Ice::Current&)’:
cameraserver.cpp:178: warning: ignoring return value of ‘int
system(const char*)’, declared with attribute warn_unused_result

recordingserver.cpp:94: warning: ignoring return value of ‘ssize_t
read(int, void*, size_t)’, declared with attribute warn_unused_result
recordingserver.cpp: In member function ‘virtual std::string
RecordingI::startStreaming(Ice::Int, const Ice::Current&)’:
recordingserver.cpp:150: warning: ignoring return value of ‘int
system(const char*)’, declared with attribute warn_unused_result
recordingserver.cpp: In member function ‘virtual jderobot::ByteSeq
RecordingI::getThumbRecording(Ice::Int, const Ice::Current&)’:
recordingserver.cpp:187: warning: ignoring return value of ‘int
system(const char*)’, declared with attribute warn_unused_result
recordingserver.cpp: In member function ‘virtual void
RecordingI::AMI_Recorder_startRecordingI::ice_response(const
jderobot::RecorderConfigPtr&)’:
recordingserver.cpp:241: warning: ignoring return value of ‘ssize_t
write(int, const void*, size_t)’, declared with attribute
warn_unused_result
recordingserver.cpp: In member function ‘virtual int
RecordingSrvApp::run(int, char**)’:
recordingserver.cpp:316: warning: ignoring return value of ‘int
pipe(int*)’, declared with attribute warn_unused_result



In file included from deviceRecorder.h:25,
                 from recorder.cpp:28:
GenericRecorder.h:99:8: warning: extra tokens at end of #endif directive
In file included from recorder.cpp:28:
deviceRecorder.h:43:8: warning: extra tokens at end of #endif directive
In file included from recorder.cpp:29:
imageRecorder.h:42:8: warning: extra tokens at end of #endif directive


In file included from deviceRecorder.cpp:22:
deviceRecorder.h:43:8: warning: extra tokens at end of #endif directive
deviceRecorder.cpp: In member function ‘virtual int
deviceRecorder::doRecording()’:
deviceRecorder.cpp:60: warning: deprecated conversion from string
constant to ‘char*’
deviceRecorder.cpp:60: warning: deprecated conversion from string
constant to ‘char*’
deviceRecorder.cpp:60: warning: deprecated conversion from string
constant to ‘char*’